Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics: track wallet address #2841

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Analytics: track wallet address #2841

merged 1 commit into from
Nov 22, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 21, 2023 •
edited
Loading

What it solves

I've added a new user property walletAddress.
The Privacy Policy for this has been updated in #2840.

How to test it

  • Open the console
  • Connect a wallet
  • See that it logs a new GTM user property

@katspaugh katspaugh requested a review from alicecha November 21, 2023 14:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://track_signer--walletweb.review-wallet-web.5afe.dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +24 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 75.92% 9981/13147
🔴 Branches 50.16% 2033/4053
🔴 Functions 58.73% 1494/2544
🟡 Lines 77.49% 9018/11637

Test suite run success

1095 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 635b5c0

alicecha
alicecha approved these changes Nov 21, 2023
View reviewed changes
Copy link

@alicecha alicecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@katspaugh katspaugh force-pushed the track-signer branch 2 times, most recently from 224922d to 635b5c0 Compare November 21, 2023 15:37
@katspaugh katspaugh added this to the 1.3.0 milestone Nov 21, 2023
@francovenica
Copy link
Contributor

LGTM:
Connected with different wallets and switching accounts in the wallet itself.
image

@katspaugh katspaugh merged commit 21002ad into dev Nov 22, 2023
27 checks passed
@katspaugh katspaugh deleted the track-signer branch November 22, 2023 07:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alicecha alicecha alicecha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Safe{Wallet}
Archived in project
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@katspaugh @francovenica @alicecha